Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solars, add IllegalComponent test. #3039

Merged
merged 6 commits into from
Mar 6, 2025

Conversation

whatston3
Copy link
Contributor

About the PR

Fixes the plasma/uranium solar panels to use our grid-based system.

Adds a test that checks all entities for illegal components in case we deprecate older systems (cough cough, solars).

Why / Balance

I goofed. Fixes https://discord.com/channels/1123826877245694004/1347163990492581908.

How to test

  1. Put up some solars, at least one of each type on Frontier Outpost, make sure they're connected to HV power.
  2. Spawn a solar control computer, set the angle to something obvious (e.g. 45 degrees)
  3. Wait until the solar panels update.

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: Plasma and uranium solar panels should work properly.

@dvir001 dvir001 self-requested a review March 6, 2025 21:46
@dvir001 dvir001 self-requested a review March 6, 2025 22:24
@dvir001 dvir001 merged commit 4d36762 into new-frontiers-14:master Mar 6, 2025
14 checks passed
FrontierATC added a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews size/S YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants