Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdvertiseComponent: No advertisements for players. #3040

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Mar 6, 2025

About the PR

The AdvertiseSystem is used to output messages from time to time, e.g. on vendors. We apply this to some mobs on expeditions. If a player takes over this character, they should stop talking.

Why / Balance

Bug.

How to test

Set a vendor's advertisement time to something very low.
Watch as the vendor spams advertisements.
Become the vendor.
Stop advertising.

Media

Requirements

Breaking changes

Changelog

🆑

  • tweak: Advertising mobs should no longer advertise when player-controlled.

@dvir001 dvir001 requested a review from whatston3 March 6, 2025 21:56
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Mar 6, 2025
@whatston3 whatston3 changed the title 2025 03 06 random speak suggestions No advertisements for players, advertisement cleanup. Mar 6, 2025
@whatston3 whatston3 changed the title No advertisements for players, advertisement cleanup. AdvertiseComponent: No advertisements for players. Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants