Use original vessel index as ID in bounty console

[arimah]

About the PR

In the bounty console, use the original vessel index as the dropdown item ID, not the new index.

Why / Balance

Just two lines above where the vessels are added, we sometimes skip items:

if (string.IsNullOrWhiteSpace(_vessels[i]))
    continue;

VesselSelector.AddItem(_vessels[i], listIndex);
listIndex++;

Unfortunately, later on in GetVessel, we use the item ID as an index into _vessels:

var id = VesselSelector.SelectedId;
if (id < _vessels.Count)
    vessel = _vessels[id];

If an item has indeed been skipped, the ID will point to the wrong index in _vessels! The simplest solution of all is to skip the listIndex dance and just use the original index, which allows us to get back to the right value in _vessels with no hassle of any kind. Easy peasy.

It appears index 1 is often something with an empty name. Unsure if this is a new bug or not, but it was recently discovered at any rate.

How to test

1. Create bounties with many different vessels.
2. Ensure the vessel is always corect.

Media

N/A

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

No.

Changelog
🆑

• fix: The Bounty Contracts PDA app should now choose the right vessel when you create a bounty.

[whatston3]

Works.

The entity with the empty string is for the sector's records. That's what gets used in the criminal records computer.