Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-211968: Add push pr reusable workflows #41

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

marcsanmi
Copy link
Contributor

@marcsanmi marcsanmi commented Jan 18, 2024

This PR adds a Push PR reusable workflows composed of several other pluggable single workflows.

These workflows have been tested in the following PRs:

Note: To test the fake prereleases flow (such as the 2nd PR) I've used a worflow_run approach in order to run the Test Build Windows workflow once the previous needed Test Build Nix fake prerelease workflows is completed. From GitHub notes, we are not going to be able to test this until this workflow is merged in the default branch.

More details here https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

@marcsanmi marcsanmi requested a review from a team January 18, 2024 16:19
@marcsanmi marcsanmi force-pushed the msanmiquel/reusable-push-pipeline branch 13 times, most recently from a50fe52 to 5a12ee0 Compare January 23, 2024 09:11
@marcsanmi marcsanmi force-pushed the msanmiquel/reusable-push-pipeline branch 5 times, most recently from b1c1006 to 6b4a04e Compare January 24, 2024 15:47
@marcsanmi marcsanmi requested review from a team and paologallinaharbur January 24, 2024 16:22
steps:
- uses: actions/checkout@v4
- uses: newrelic/newrelic-infra-checkers@v1
# TODO: consider adding semgrep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this and at most add a task in Jira

Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive improvement! Thanks for taking care!

@marcsanmi marcsanmi force-pushed the msanmiquel/reusable-push-pipeline branch 9 times, most recently from 445814b to b055479 Compare January 31, 2024 08:33
@marcsanmi marcsanmi force-pushed the msanmiquel/reusable-push-pipeline branch from b055479 to be9d8ce Compare January 31, 2024 09:13
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!!

@marcsanmi marcsanmi merged commit 3f350fc into main Jan 31, 2024
5 checks passed
@marcsanmi marcsanmi deleted the msanmiquel/reusable-push-pipeline branch January 31, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants