-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR-211968: Add push pr reusable workflows #41
Conversation
a50fe52
to
5a12ee0
Compare
b1c1006
to
6b4a04e
Compare
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: newrelic/newrelic-infra-checkers@v1 | ||
# TODO: consider adding semgrep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this and at most add a task in Jira
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a massive improvement! Thanks for taking care!
445814b
to
b055479
Compare
b055479
to
be9d8ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!!
This PR adds a Push PR reusable workflows composed of several other pluggable single workflows.
These workflows have been tested in the following PRs:
Note: To test the fake prereleases flow (such as the 2nd PR) I've used a
worflow_run
approach in order to run theTest Build Windows
workflow once the previous neededTest Build Nix fake prerelease
workflows is completed. From GitHub notes, we are not going to be able to test this until this workflow is merged in the default branch.More details here https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run