-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apache Druid integration docs #16426
Conversation
|
Hi @RamanaReddy8801 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
⏳ Netlify Preview Deployment InformationThis comment will auto update when your preview build is ready |
Hi @RamanaReddy8801! Since this is a brand new doc, I'll have to bring this into an upcoming sprint to review and publish. I can get it into our March 18th sprint if that works! |
@bradleycamacho, We're fine to review this document during the upcoming sprint. However, it's crucial to ensure there are no delays, as this quickstart must be live by the end of the month. |
Hi @RamanaReddy8801! I'm going to be pushing up some changes that are unfinished over the next day or so. Please ignore anything that is obviously an error or half written - no need to worry as it'll be fixed! |
...nt/docs/infrastructure/host-integrations/host-integrations-list/apache-druid-integration.mdx
Outdated
Show resolved
Hide resolved
...nt/docs/infrastructure/host-integrations/host-integrations-list/apache-druid-integration.mdx
Show resolved
Hide resolved
...nt/docs/infrastructure/host-integrations/host-integrations-list/apache-druid-integration.mdx
Outdated
Show resolved
Hide resolved
...nt/docs/infrastructure/host-integrations/host-integrations-list/apache-druid-integration.mdx
Outdated
Show resolved
Hide resolved
druid.extensions.loadList=["druid-hdfs-storage", "druid-kafka-indexing-service", "druid-datasketches", "druid-multi-stage-query", "prometheus-emitter"] | ||
``` | ||
|
||
2. Add the code snippets in the right column to the files in the left column: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this sentence parallel left --> right of the table, so either add the snippets to the left column and file paths to the right (Add the code snippets in the left column to the file paths in the right column), or change the wording to:
"In the file paths listed in the left column, add the code snippets listed in the right columns."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know this is a huge pain but the parallelism will def help
...nt/docs/infrastructure/host-integrations/host-integrations-list/apache-druid-integration.mdx
Outdated
Show resolved
Hide resolved
...nt/docs/infrastructure/host-integrations/host-integrations-list/apache-druid-integration.mdx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change that should definitely be made before release is making "New Relic's" style guide compliant. Otherwise the instructions make sense + were follow..able. I made some recommendations about language that you can take or leave. Good job!
Ticket : https://issues.newrelic.com/browse/NR-234859
Description: Apache Druid - created new integration documentation for Apache Druid.
Preview image: