Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Druid integration docs #16426

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

RamanaReddy8801
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 commented Mar 6, 2024

Ticket : https://issues.newrelic.com/browse/NR-234859

Description: Apache Druid - created new integration documentation for Apache Druid.

Preview image:
screencapture-localhost-8000-docs-infrastructure-host-integrations-host-integrations-list-apache-druid-integration-2024-03-19-13_46_42

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Mar 6, 2024

Hi @RamanaReddy8801 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit e414c8f
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6605f19686c8c600082111f6
😎 Deploy Preview https://deploy-preview-16426--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 6, 2024

Netlify Preview Deployment Information

This comment will auto update when your preview build is ready

@bradleycamacho bradleycamacho self-assigned this Mar 8, 2024
@bradleycamacho
Copy link
Contributor

Hi @RamanaReddy8801! Since this is a brand new doc, I'll have to bring this into an upcoming sprint to review and publish. I can get it into our March 18th sprint if that works!

@RamanaReddy8801
Copy link
Contributor Author

Hi @RamanaReddy8801! Since this is a brand new doc, I'll have to bring this into an upcoming sprint to review and publish. I can get it into our March 18th sprint if that works!

@bradleycamacho, We're fine to review this document during the upcoming sprint. However, it's crucial to ensure there are no delays, as this quickstart must be live by the end of the month.

@bradleycamacho
Copy link
Contributor

Hi @RamanaReddy8801! I'm going to be pushing up some changes that are unfinished over the next day or so. Please ignore anything that is obviously an error or half written - no need to worry as it'll be fixed!

druid.extensions.loadList=["druid-hdfs-storage", "druid-kafka-indexing-service", "druid-datasketches", "druid-multi-stage-query", "prometheus-emitter"]
```

2. Add the code snippets in the right column to the files in the left column:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this sentence parallel left --> right of the table, so either add the snippets to the left column and file paths to the right (Add the code snippets in the left column to the file paths in the right column), or change the wording to:

"In the file paths listed in the left column, add the code snippets listed in the right columns."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is a huge pain but the parallelism will def help

Copy link
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change that should definitely be made before release is making "New Relic's" style guide compliant. Otherwise the instructions make sense + were follow..able. I made some recommendations about language that you can take or leave. Good job!

@bradleycamacho bradleycamacho merged commit c260fc4 into newrelic:develop Mar 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants