Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for APM agent setup with ECS env. #18916

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Add docs for APM agent setup with ECS env. #18916

merged 7 commits into from
Oct 16, 2024

Conversation

umaannamalai
Copy link
Contributor

This PR adds a guide for setting up language agents/ the infra agent within an ECS/ Fargate environment.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Hi @umaannamalai 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 2a2a5dd
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/670feb3c33906000086f636e
😎 Deploy Preview https://deploy-preview-18916--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jaffinito
jaffinito approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@jaffinito jaffinito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There a few spots where you could replace the full docs URL withe shorthand version, but I don't think that should hold up approval.

@umaannamalai umaannamalai marked this pull request as ready for review October 10, 2024 21:41
@akristen akristen self-assigned this Oct 16, 2024
@akristen akristen added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 16, 2024
akristen
akristen reviewed Oct 16, 2024
View reviewed changes
...nt/docs/infrastructure/elastic-container-service-integration/monitor-ecs-with-apm-agents.mdx Outdated
For more information, please see our [ECS integration install guide](https://docs.newrelic.com/docs/infrastructure/elastic-container-service-integration/install-ecs-integration/).


Example full task definition file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a code comment somewhere that identifies the changes specific to setting up a sidecar container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task definition file was meant to show the full setup of the sidecar and the agent. I can add it under a new main heading to clarify that

@akristen akristen merged commit 3741584 into newrelic:develop Oct 16, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaffinito jaffinito jaffinito approved these changes

@akristen akristen akristen approved these changes

Assignees

@akristen akristen

Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umaannamalai @jaffinito @akristen