-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-host Apache: Fix logic that allows mixture of Linux and Window instructions #18972
base: develop
Are you sure you want to change the base?
Conversation
…ws instructions Remove references to the guided install because that's not a clear path.
Hi @rhetoric101 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- filePath: 'src/install/apache/install-infra.mdx' | ||
|
||
# Step 4: Display the Apache integration download and installation instructions | ||
# based on their answer in question 1 above. Note the overrides: | ||
- filePath: "src/install/apache/linux/install-apt.mdx" | ||
overrides: | ||
- filePath: "src/install/apache/linux/install-apt.mdx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 57 nests install via APT into the default flow for the branching logic. This is persistent throughout all of these OHIs, and it's why all of them have "APT" int he right nav. To fix this, we need to add a new mdx file that's a "default install" step, then shift - filePath: "src/install/apache/linux/install-apt.mdx"
as an option, not the default.
I make this fix in /install/microsoft-sql.yml
on lines 62-64 for an example. :)
Co-authored-by: ally sassman <[email protected]>
Co-authored-by: ally sassman <[email protected]>
No description provided.