Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-host Apache: Fix logic that allows mixture of Linux and Window instructions #18972

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

rhetoric101
Copy link
Contributor

No description provided.

…ws instructions

Remove references to the guided install because that's not a clear path.
@rhetoric101 rhetoric101 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Oct 16, 2024
Copy link

Hi @rhetoric101 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 5af1d18
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6719779c78e44f0008b61d74
😎 Deploy Preview https://deploy-preview-18972--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rhetoric101 rhetoric101 self-assigned this Oct 16, 2024
@rhetoric101 rhetoric101 requested review from akristen and removed request for ally-sassman October 16, 2024 00:30
- filePath: 'src/install/apache/install-infra.mdx'

# Step 4: Display the Apache integration download and installation instructions
# based on their answer in question 1 above. Note the overrides:
- filePath: "src/install/apache/linux/install-apt.mdx"
overrides:
- filePath: "src/install/apache/linux/install-apt.mdx"
Copy link
Contributor

@akristen akristen Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 57 nests install via APT into the default flow for the branching logic. This is persistent throughout all of these OHIs, and it's why all of them have "APT" int he right nav. To fix this, we need to add a new mdx file that's a "default install" step, then shift - filePath: "src/install/apache/linux/install-apt.mdx" as an option, not the default.

I make this fix in /install/microsoft-sql.yml on lines 62-64 for an example. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants