Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php-agent-compatibility-requirements.mdx for Yii 1 & 2 #19018

Closed
wants to merge 1 commit into from

Conversation

razvanphp
Copy link

Yii 1.x support is still there, so for completion and given that this version is still widely used, I've udpated the docs to reflect that.

See: newrelic/newrelic-php-agent#821

Related to #16030

Yii 1.x support is still there, so for completion and given that this version is still widely used, I've udpated the docs to reflect that.

See: newrelic/newrelic-php-agent#821
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Hi @razvanphp 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 702c966
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6714a1beb32a7600087a83ec
😎 Deploy Preview https://deploy-preview-19018--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nbaenam nbaenam self-requested a review October 21, 2024 07:11
@nbaenam nbaenam self-assigned this Oct 21, 2024
@nbaenam nbaenam added content requests related to docs site content from_external Identifies issues/PRs from non-Relics labels Oct 21, 2024
@nbaenam
Copy link
Contributor

nbaenam commented Oct 21, 2024

Added a message in the php-agent channel to verify this info.

@nbaenam
Copy link
Contributor

nbaenam commented Oct 23, 2024

Hi @razvanphp, the page is already updated and our engineers think this change is not needed. Thanks for chiming in!

@nbaenam nbaenam closed this Oct 23, 2024
@razvanphp
Copy link
Author

Can you please reconsider this?

If you look at the implementation PR for Yii2 (newrelic/newrelic-php-agent#848), you can see yourself it is a separate implementation for Yii v1 and v2, as they are not compatible.

As a daily user of this framework, I know the community and I can tell you it's confusing if you specify just one on the documentation. Also, all the other frameworks have all historical versions specified in the documentation. Why have it different just for this one? Before this change, the documentation was specifying only 1.x, which still holds true today.

I don't see why NewRelic will not want to keep an up-to-date and accurate documentation....

@nbaenam
Copy link
Contributor

nbaenam commented Oct 25, 2024

Hi @razvanphp, I've consulted with the eng team again. If they think this must be updated, I'll open a new PR and I'll let you know. Thank you for chiming in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_external Identifies issues/PRs from non-Relics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants