-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update php-agent-compatibility-requirements.mdx for Yii 1 & 2 #19018
Conversation
Yii 1.x support is still there, so for completion and given that this version is still widely used, I've udpated the docs to reflect that. See: newrelic/newrelic-php-agent#821
|
Hi @razvanphp 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Added a message in the php-agent channel to verify this info. |
Hi @razvanphp, the page is already updated and our engineers think this change is not needed. Thanks for chiming in! |
Can you please reconsider this? If you look at the implementation PR for Yii2 (newrelic/newrelic-php-agent#848), you can see yourself it is a separate implementation for Yii v1 and v2, as they are not compatible. As a daily user of this framework, I know the community and I can tell you it's confusing if you specify just one on the documentation. Also, all the other frameworks have all historical versions specified in the documentation. Why have it different just for this one? Before this change, the documentation was specifying only 1.x, which still holds true today. I don't see why NewRelic will not want to keep an up-to-date and accurate documentation.... |
Hi @razvanphp, I've consulted with the eng team again. If they think this must be updated, I'll open a new PR and I'll let you know. Thank you for chiming in! |
Yii 1.x support is still there, so for completion and given that this version is still widely used, I've udpated the docs to reflect that.
See: newrelic/newrelic-php-agent#821
Related to #16030