-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding candidate and relationship btw OTel and kinesis stream #1744
Open
AravindKumar8520
wants to merge
5
commits into
newrelic:main
Choose a base branch
from
AravindKumar8520:NR-293090
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f96321d
feat: Adding candidate and relationship for OTelto kinesis stream
AravindKumar8520 cec0603
Merge branch 'main' into NR-293090
AravindKumar8520 6b089d0
Merge branch 'main' into NR-293090
AravindKumar8520 9539f4e
Merge branch 'main' into NR-293090
AravindKumar8520 53c82eb
Merge branch 'main' into NR-293090
AravindKumar8520 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| category: AWSKINESISSTREAM | ||
| lookups: | ||
| - entityTypes: | ||
| - domain: INFRA | ||
| type: AWSKINESISSTREAM | ||
| tags: | ||
| matchingMode: ALL | ||
| predicates: | ||
| - tagKeys: ["aws.Arn"] | ||
| field: cloudResourceId | ||
| onMatch: | ||
| onMultipleMatches: RELATE_ALL | ||
| onMiss: | ||
| action: CREATE_UNINSTRUMENTED | ||
| uninstrumented: | ||
| type: AWSKINESISSTREAM |
22 changes: 22 additions & 0 deletions
22
relationships/synthesis/EXT-SERVICE-to-INFRA-KINESISSTREAM.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| relationships: | ||
| - name: extServiceCallsInfraKinesisStream | ||
| version: "1" | ||
| origins: | ||
| - Distributed Tracing | ||
| conditions: | ||
| - attribute: eventType | ||
| anyOf: [ "Span" ] | ||
| - attribute: rpc.service | ||
| anyOf: [ "kinesis" ] | ||
| relationship: | ||
| expires: P75M | ||
| relationshipType: CALLS | ||
| source: | ||
| extractGuid: | ||
| attribute: entity.guid | ||
| target: | ||
| lookupGuid: | ||
| candidateCategory: AWSKINESISSTREAM | ||
| fields: | ||
| - field: cloudResourceId | ||
| attribute: cloud.resource_id | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this condition will relate anything that has a span with rpc.service=kinesis.
not sure I follow how we are making sure is ext-service/otel only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're primarily receiving data in spans, i guess we should opt for:
origins: - Distributed Tracinginstead of
origins: - OpentelemetryCurrently, no pull request exists for APM to AWS Kinesis streaming. We anticipate that APM data will continue to arrive in span format; if it's in metrics, we'll use APM Metrics. Do we need to wait for the APM to AWS Kinesis stream PR?