Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify metric titles between APM & OTEL #1766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tkarai
Copy link
Contributor

@tkarai tkarai commented Oct 10, 2024

Relevant information

Unify Throughout, Response time and Error rate golden metric titles between APM and OpenTelemetry service applications. This will make the UI to display the same column names for these two closely related entity types.

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'EXT-PIXIE_DNS' on synthesis - Exception: Synthesis rules match 'EXT-SERVICE' domainType with the given test data: 'MetricRaw.json file - #1' data point. Expecting synthesis rules to match 'EXT-PIXIE_DNS'. Please review test data and synthesis rules.

* Error VALIDATING domainType: 'EXT-PIXIE_DNS' on synthesis - Exception: No entity matches 'EXT-PIXIE_DNS' synthesis rules for the given test data: 'Span.json file - #1' data point. Please review test data and synthesis rules.

@entityBot entityBot dismissed their stale review October 10, 2024 17:15

Let's validate those changes.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error VALIDATING domainType: 'EXT-PIXIE_DNS' on synthesis - Exception: Synthesis rules match 'EXT-SERVICE' domainType with the given test data: 'MetricRaw.json file - #1' data point. Expecting synthesis rules to match 'EXT-PIXIE_DNS'. Please review test data and synthesis rules.

* Error VALIDATING domainType: 'EXT-PIXIE_DNS' on synthesis - Exception: No entity matches 'EXT-PIXIE_DNS' synthesis rules for the given test data: 'Span.json file - #1' data point. Please review test data and synthesis rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants