-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Selector based injection for all available agents #87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
===========================================
+ Coverage 47.74% 62.09% +14.34%
===========================================
Files 13 22 +9
Lines 976 1224 +248
===========================================
+ Hits 466 760 +294
+ Misses 446 392 -54
- Partials 64 72 +8 ☔ View full report in Codecov by Sentry. |
I'm going to assume you don't actually need review yet from the agent teams who are getting pinged as code owners. When you need our review on something please ping each of the teams either with an @ here or on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments and still reviewing it. I believe there is a lot of room to simplify the code by removing couple of interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚀 Great stuff @danielstokes
Co-authored-by: Marty T <[email protected]>
Description
This POC uses selectors rather than annotations to inject instrumentation.
This replicates secrets from the
newrelic
namespace to the pod namespace as needed. 1This merges the
main
branch andfeat/poc
features, along with some additional changesType of change
Checklist:
Footnotes
There's no mechanism to update/patch/delete secrets in the case of a collision or rotating secrets ↩