Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Selector based injection for all available agents #87

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

danielstokes
Copy link
Contributor

@danielstokes danielstokes commented Sep 13, 2024

Description

This POC uses selectors rather than annotations to inject instrumentation.
This replicates secrets from the newrelic namespace to the pod namespace as needed. 1
This merges the main branch and feat/poc features, along with some additional changes

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Footnotes

  1. There's no mechanism to update/patch/delete secrets in the case of a collision or rotating secrets

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 69.64286% with 238 lines in your changes missing coverage. Please review.

Project coverage is 62.09%. Comparing base (5adabea) to head (4a85cbc).

Files with missing lines Patch % Lines
src/apm/helper.go 46.55% 80 Missing and 13 partials ⚠️
src/apm/golang.go 63.44% 42 Missing and 11 partials ⚠️
src/api/v1alpha2/instrumentation_webhook.go 47.36% 15 Missing and 5 partials ⚠️
src/instrumentation/podmutator.go 87.20% 11 Missing and 5 partials ⚠️
src/instrumentation/instrumentation_validator.go 0.00% 13 Missing ⚠️
src/api/v1alpha2/zz_generated.deepcopy.go 0.00% 11 Missing ⚠️
src/apm/dotnet.go 87.50% 1 Missing and 4 partials ⚠️
src/api/v1alpha2/instrumentation_types.go 63.63% 4 Missing ⚠️
src/instrumentation/instrumentation_defaulter.go 0.00% 4 Missing ⚠️
src/internal/version/main.go 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #87       +/-   ##
===========================================
+ Coverage   47.74%   62.09%   +14.34%     
===========================================
  Files          13       22        +9     
  Lines         976     1224      +248     
===========================================
+ Hits          466      760      +294     
+ Misses        446      392       -54     
- Partials       64       72        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielstokes danielstokes marked this pull request as ready for review September 25, 2024 17:15
@danielstokes danielstokes requested a review from a team as a code owner September 25, 2024 17:15
@danielstokes danielstokes requested a review from a team September 25, 2024 17:15
@danielstokes danielstokes requested review from a team as code owners September 25, 2024 17:15
@TimPansino
Copy link
Contributor

I'm going to assume you don't actually need review yet from the agent teams who are getting pinged as code owners. When you need our review on something please ping each of the teams either with an @ here or on Slack.

@danielstokes danielstokes changed the title POC - Selector based injection for all available agents feat: Selector based injection for all available agents Oct 1, 2024
src/apm/java.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ramkrishankumarN ramkrishankumarN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and still reviewing it. I believe there is a lot of room to simplify the code by removing couple of interfaces.

Copy link
Contributor

@ramkrishankumarN ramkrishankumarN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
🚀 Great stuff @danielstokes

.github/CODEOWNERS Outdated Show resolved Hide resolved
@ramkrishankumarN ramkrishankumarN merged commit 1d9490e into main Oct 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants