Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tests for New Operator Version #117

Merged
merged 16 commits into from
Oct 16, 2024
Merged

Fix Tests for New Operator Version #117

merged 16 commits into from
Oct 16, 2024

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Oct 11, 2024 •
edited
Loading

  • Fix tests for new operator version by switching all test app helm charts to pod selectors.
  • Add read only DockerHub token to fix rate limiting.
  • NOTE: PHP seems to be working locally, but there's some problem getting the data to report correctly in CI.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 11, 2024
View reviewed changes
tests/python/main.py Fixed Show fixed Hide fixed
@TimPansino TimPansino force-pushed the fix-tests-new-operator-version branch from 9296b4a to 3ec782e Compare October 11, 2024 23:03
@TimPansino
Copy link
Contributor Author

I think this PR is going to be blocked until the new helm charts are published.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
tests/python/main.py Dismissed Show dismissed Hide dismissed
@TimPansino TimPansino changed the title Fix Tests for New Operator Version [DO NOT MERGE] Fix Tests for New Operator Version Oct 14, 2024
@TimPansino TimPansino marked this pull request as ready for review October 14, 2024 18:04
@TimPansino TimPansino requested review from a team as code owners October 14, 2024 18:04
fallwith
fallwith previously approved these changes Oct 14, 2024
View reviewed changes
jtduffy
jtduffy previously approved these changes Oct 14, 2024
View reviewed changes
@TimPansino TimPansino dismissed stale reviews from jtduffy and fallwith via 7363a8d October 14, 2024 19:36
@TimPansino
Copy link
Contributor Author

As a random side note, anyone know why reviews are being dismissed when that setting isn't even enabled on branch protections?

@chynesNR
Copy link
Member

As a random side note, anyone know why reviews are being dismissed when that setting isn't even enabled on branch protections?

I believe it's enabled at the org level now?

@tippmar-nr
Copy link
Member

As a random side note, anyone know why reviews are being dismissed when that setting isn't even enabled on branch protections?

@TimPansino It's probably coming from the global config settings that were forced on all repos. It's obnoxious on the one hand, especially when there are comments that have to be addressed -- but it's also a reasonable protection against someone slipping in unreviewed changes.

@TimPansino TimPansino merged commit 3cc7b64 into main Oct 16, 2024
27 of 49 checks passed
@TimPansino TimPansino deleted the fix-tests-new-operator-version branch October 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tippmar-nr tippmar-nr tippmar-nr left review comments

@fallwith fallwith fallwith approved these changes

@jtduffy jtduffy jtduffy approved these changes

@umaannamalai umaannamalai umaannamalai approved these changes

@svetlanabrennan svetlanabrennan svetlanabrennan approved these changes

@deleonenriqueta deleonenriqueta deleonenriqueta approved these changes

@bduranleau-nr bduranleau-nr bduranleau-nr approved these changes

@chynesNR chynesNR chynesNR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@TimPansino @chynesNR @tippmar-nr @fallwith @jtduffy @umaannamalai @svetlanabrennan @deleonenriqueta @bduranleau-nr