-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tests for New Operator Version #117
Conversation
TimPansino
commented
Oct 11, 2024
•
edited
Loading
edited
- Fix tests for new operator version by switching all test app helm charts to pod selectors.
- Add read only DockerHub token to fix rate limiting.
- NOTE: PHP seems to be working locally, but there's some problem getting the data to report correctly in CI.
9296b4a
to
3ec782e
Compare
I think this PR is going to be blocked until the new helm charts are published. |
As a random side note, anyone know why reviews are being dismissed when that setting isn't even enabled on branch protections? |
I believe it's enabled at the org level now? |
@TimPansino It's probably coming from the global config settings that were forced on all repos. It's obnoxious on the one hand, especially when there are comments that have to be addressed -- but it's also a reasonable protection against someone slipping in unreviewed changes. |