Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java e2e tests #16

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Add Java e2e tests #16

merged 5 commits into from
Jun 2, 2024

Conversation

jasonjkeller
Copy link
Contributor

@jasonjkeller jasonjkeller commented May 29, 2024

@jasonjkeller jasonjkeller self-assigned this May 29, 2024
@jasonjkeller

This comment was marked as resolved.

@jasonjkeller

This comment was marked as resolved.

@tippmar-nr
Copy link
Member

tippmar-nr commented May 30, 2024

Actually, the problem is that the "Build init container for e2e test" step isn't setting an agent version:

#4 [2/3] ADD https://download.newrelic.com/newrelic/java-agent/newrelic-agent//newrelic-agent-.jar /newrelic-agent.jar
#4 ERROR: invalid response status 404

@jasonjkeller Is there an "unversioned" latest release of the Java agent that you can reference here? We had to do a little bit of dancing on the .NET side to add an unversioned tarball to our release process to accommodate this particular use case. There really won't be a way for the tests to be supplied with a version number - so I think Java will either need an unversioned jar file or some other way to get "latest version".

Edit: Looks like you could reference https://download.newrelic.com/newrelic/java-agent/newrelic-agent/current/newrelic-agent.jar and be in good shape!

@jasonjkeller
Copy link
Contributor Author

@tippmar-nr Thanks. I ended up moving the agent download logic into a little shell script invoked by the init container Dockerfile that will download the agent version matching the build arg if it's provided, otherwise it will just default to the current version. That seems to have done the trick.

@jasonjkeller jasonjkeller merged commit 148ee50 into main Jun 2, 2024
13 checks passed
@jasonjkeller jasonjkeller deleted the add-java-e2e-test branch June 2, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants