Add e2e tests for Ruby #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerized Ruby app, k8s setup, CI testing
tippmar-nr
reviewed
Jun 5, 2024
.github/workflows/ruby.yml
Outdated
| runs-on: ubuntu-latest | ||
| needs: check-modified-files | ||
| # run only if files were modified or the workflow was manually invoked | ||
| if: needs.check-modified-files.outputs.files-changed == 'true' || github.event_name == 'workflow_dispatch' |
There was a problem hiding this comment.
You will probably want to add || (github.event_name == 'release' && endsWith(github.ref_name, '_ruby') to ensure the tests job runs on release.
There was a problem hiding this comment.
The publish job depends on the test job to run, but from what I understand, publish won't run if test job conditions aren't met. So this is a great call out!
Other agents appear to be missing this condition as well. I'll update Ruby's.
fallwith
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerized Ruby app, k8s setup, CI testing