Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: .NET workflow tweaks #27

Merged
merged 13 commits into from
Jun 7, 2024
Merged

ci: .NET workflow tweaks #27

merged 13 commits into from
Jun 7, 2024

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Jun 5, 2024

  • Integrates with the test.yml reusable workflow, had to make a couple minor changes.
  • Modified file header to use an SPDX-License-Identifier tag as suggested in a thread in #agent-dev, makes things much more compact
  • Adds inputs for workflow_dispatch to optionally allow publishing an arbitrary version of the agent without requiring a release tag
  • Only sets the latest tag when publishing from a release trigger or when request during manual run
  • Updates workflow triggers to match other agent workflows, specifying paths to consider before triggering. This might make the check-modified-files workflow unnecessary.

@tippmar-nr tippmar-nr marked this pull request as draft June 5, 2024 20:30
@tippmar-nr tippmar-nr changed the title ci: .NET workflow tweaks DRAFT ci: .NET workflow tweaks Jun 5, 2024
@tippmar-nr tippmar-nr changed the title DRAFT ci: .NET workflow tweaks ci: .NET workflow tweaks Jun 5, 2024
@tippmar-nr tippmar-nr marked this pull request as ready for review June 5, 2024 20:49
@mrickard mrickard self-assigned this Jun 7, 2024
@tippmar-nr tippmar-nr enabled auto-merge (squash) June 7, 2024 20:26
Copy link
Member

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @tippmar-nr !

@tippmar-nr tippmar-nr merged commit 96187bd into main Jun 7, 2024
14 checks passed
@tippmar-nr tippmar-nr deleted the ci/dotnet-workflow-tweaks branch June 7, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants