Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile Scripting Upgrades #77

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Makefile Scripting Upgrades #77

merged 2 commits into from
Jul 25, 2024

Conversation

TimPansino
Copy link
Contributor

  • Update Makefile scripting with some improvements.
    • Separate operator namespace from test app namespace to prevent issues where the wait condition was waiting forever on the wrong item.
    • Change minikube image build to docker build to avoid issues where image builds fail silently and don't stop the script from continuing.

@TimPansino TimPansino requested a review from a team as a code owner July 25, 2024 16:28
@TimPansino TimPansino requested review from a team July 25, 2024 16:28
@TimPansino TimPansino merged commit f3ac661 into main Jul 25, 2024
8 checks passed
@TimPansino TimPansino deleted the feature-makefile-scripting-upgrades branch July 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tippmar-nr tippmar-nr tippmar-nr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimPansino @tippmar-nr