Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): prototype support yaml and json as inputs for command flags #1481

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sanderblue
Copy link
Contributor

@sanderblue sanderblue commented Jun 27, 2023

⚠️ WIP ⚠️

  • Validate flags by name and type
  • Add tests

@sanderblue sanderblue force-pushed the feat/support-yaml-json-as-flags branch from c772bf0 to 5238b16 Compare June 27, 2023 21:38
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1481 (bfd4c0e) into main (13004ac) will decrease coverage by 0.29%.
The diff coverage is 23.86%.

❗ Current head bfd4c0e differs from pull request most recent head ecc47ac. Consider uploading reports for the commit ecc47ac to get more accurate results

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   48.01%   47.73%   -0.29%     
==========================================
  Files         123      125       +2     
  Lines        7445     7533      +88     
==========================================
+ Hits         3575     3596      +21     
- Misses       3728     3795      +67     
  Partials      142      142              
Impacted Files Coverage Δ
internal/utils/utils.go 27.86% <0.00%> (-4.83%) ⬇️
internal/synthetics/command_monitor_run.go 10.34% <10.34%> (ø)
internal/utils/command_do.go 32.35% <32.35%> (ø)
internal/synthetics/command_monitor.go 16.66% <100.00%> (+5.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanderblue sanderblue force-pushed the feat/support-yaml-json-as-flags branch from 13a4900 to bfd4c0e Compare June 28, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant