-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Use arm64 runners for arm64 container integration tests #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e CI workflow to run arm64 tests on an arm runner
tippmar-nr
changed the title
**DRAFT** test: Use arm64 runners for arm64 container integration tests
test: Use arm64 runners for arm64 container integration tests
Jan 22, 2025
chynesNR
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2959 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 470 470
Lines 29953 29953
Branches 3330 3330
=======================================
Hits 24504 24504
Misses 4657 4657
Partials 792 792
Flags with carried forward coverage won't be shown. Click here to find out more. |
jaffinito
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates container integration test workflow to split amd64 and arm64 tests to two separate jobs, each running on an appropriate Github runner. Also removed the use of Qemu in the workflow, as it's no longer required.
Tests were updated to add an "Architecture" trait so it's easy to divide them between the two jobs.
Local execution is expected to remain unchanged, still needing to leverage Qemu. The magic is in the
BUILD_ARCH
environment variable -- when present, we use the specified architecture to build the container test app; when not present (i.e., running local), we hard-code it toamd64
.An example workflow run is at https://github.com/newrelic/newrelic-dotnet-agent/actions/runs/12917552676/job/36024160825