Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use arm64 runners for arm64 container integration tests #2959

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Jan 22, 2025

Updates container integration test workflow to split amd64 and arm64 tests to two separate jobs, each running on an appropriate Github runner. Also removed the use of Qemu in the workflow, as it's no longer required.

Tests were updated to add an "Architecture" trait so it's easy to divide them between the two jobs.

Local execution is expected to remain unchanged, still needing to leverage Qemu. The magic is in the BUILD_ARCH environment variable -- when present, we use the specified architecture to build the container test app; when not present (i.e., running local), we hard-code it to amd64.

An example workflow run is at https://github.com/newrelic/newrelic-dotnet-agent/actions/runs/12917552676/job/36024160825

@tippmar-nr tippmar-nr changed the title **DRAFT** test: Use arm64 runners for arm64 container integration tests test: Use arm64 runners for arm64 container integration tests Jan 22, 2025
@tippmar-nr tippmar-nr marked this pull request as ready for review January 22, 2025 22:03
@tippmar-nr tippmar-nr requested a review from a team as a code owner January 22, 2025 22:03
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@tippmar-nr tippmar-nr enabled auto-merge (squash) January 23, 2025 16:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (f622a40) to head (d8997b2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2959   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files         470      470           
  Lines       29953    29953           
  Branches     3330     3330           
=======================================
  Hits        24504    24504           
  Misses       4657     4657           
  Partials      792      792           
Flag Coverage Δ
Agent 82.76% <ø> (ø)
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tippmar-nr tippmar-nr merged commit ce5b2c4 into main Jan 23, 2025
95 of 96 checks passed
@tippmar-nr tippmar-nr deleted the test/arm64-linux-tests-workflow branch January 23, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants