Nr 318119 auto collect stdout & stderr logs #320
+339
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent/Utilities/NRLogger.m
Outdated
| @@ -346,7 +357,6 @@ - (NSData*) jsonDictionary:(NSDictionary*)message { | |||
|
|
|||
|
|
|||
| NSMutableDictionary *providedAttributes = [message mutableCopy]; | |||
| [providedAttributes removeObjectsForKeys:@[NRLogMessageLevelKey,NRLogMessageFileKey,NRLogMessageLineNumberKey,NRLogMessageMethodKey,NRLogMessageTimestampKey,NRLogMessageMessageKey]]; | |||
There was a problem hiding this comment.
The intention of this line is to remove reserved attributes from user provided attributes when passed to NewRelic.logAttributes.
There was a problem hiding this comment.
Do you still want to remove this line? If so can you explain why?
cdillard-NewRelic
requested review from
cdillard-NewRelic
and removed request for
cdillard-NewRelic
… look further into it
|
|
||
|
|
||
| // Note: Disabled by default. Enable or disable (default) flag to enable auto collect of stdout. | ||
| //NewRelic.enableFeatures([NRMAFeatureFlags.NRFeatureFlag_RedirectStdOutStdErr]) |
There was a problem hiding this comment.
Sounds like John would like AutoCollectedLogs to be on by default. But we should double check with him and Android.
…orrectly." This reverts commit 28790a5.
…ct if remote logging is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.