Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nr 318119 auto collect stdout & stderr logs #320

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Conversation

mbruin-NR
Copy link
Contributor

No description provided.

@@ -346,7 +357,6 @@ - (NSData*) jsonDictionary:(NSDictionary*)message {


NSMutableDictionary *providedAttributes = [message mutableCopy];
[providedAttributes removeObjectsForKeys:@[NRLogMessageLevelKey,NRLogMessageFileKey,NRLogMessageLineNumberKey,NRLogMessageMethodKey,NRLogMessageTimestampKey,NRLogMessageMessageKey]];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention of this line is to remove reserved attributes from user provided attributes when passed to NewRelic.logAttributes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still want to remove this line? If so can you explain why?

@mbruin-NR mbruin-NR marked this pull request as ready for review October 24, 2024 21:08


// Note: Disabled by default. Enable or disable (default) flag to enable auto collect of stdout.
//NewRelic.enableFeatures([NRMAFeatureFlags.NRFeatureFlag_RedirectStdOutStdErr])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like John would like AutoCollectedLogs to be on by default. But we should double check with him and Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants