Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NR_EXT log lines #226

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

keegoid-nr
Copy link
Contributor

Don't print any NR_EXT lines when logsEnabled is false, including the startup line.

Don't print any NR_EXT lines when `logsEnabled` is false,
including the startup line.
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (d0a6c2e) to head (59f5db6).
Report is 1 commits behind head on main.

Files Patch % Lines
util/logger.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   81.28%   80.56%   -0.73%     
==========================================
  Files          24       24              
  Lines        1234     1250      +16     
==========================================
+ Hits         1003     1007       +4     
- Misses        164      177      +13     
+ Partials       67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaudharysaket chaudharysaket self-requested a review July 31, 2024 06:37
@chaudharysaket chaudharysaket merged commit 558cbb4 into newrelic:main Jul 31, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants