Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW_RELIC_ENABLED Env issue #233

Merged
merged 3 commits into from
Sep 11, 2024
Merged

NEW_RELIC_ENABLED Env issue #233

merged 3 commits into from
Sep 11, 2024

Conversation

chaudharysaket
Copy link
Contributor

@chaudharysaket chaudharysaket commented Sep 5, 2024 •
edited
Loading

  • Solves github issue related to Extension not handling some environment variables
  • Extension should be a no-op if NEW_RELIC_ENABLED=false or NEW_RELIC_AGENT_ENABLED=false

@chaudharysaket chaudharysaket changed the title Env issue [testing] NEW_RELIC_ENABLED Env issue Sep 11, 2024
mirackara
mirackara approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@mirackara mirackara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaudharysaket chaudharysaket merged commit 2081151 into newrelic:main Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirackara mirackara mirackara approved these changes

@iamemilio iamemilio Awaiting requested review from iamemilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaudharysaket @mirackara