Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove ErrorHandler wrapper for PHPs 8.0+
Agent for PHPs 8.0+ uses observer API to hook into Zend Engine, which allows offers better out-of-the-box instrumentation of user exception handler. When observer API is used, there's no need to wrap exception handlers to record errors.
- Loading branch information
3d90b20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is true, I was using PHP 8.2 and had absolutely no error reported in NewRelic.
3d90b20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvanphp This PR is now based on #877, which has the fix that addresses this problem.
3d90b20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvanphp Your patience and collaboration is greatly appreciated! π The tests revealing this problem, which I mention here, are passing. However, I would appreciate if you could verify, that the agent built from this PR reports errors in your test environment.