chore(agent): define major version length

newrelic · Apr 15, 2024 · 55c1e1e · 55c1e1e
1 parent 0fc0bde
commit 55c1e1e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/agent/fw_support.c b/agent/fw_support.c
@@ -11,6 +11,8 @@
 #include "util_memory.h"
 #include "util_strings.h"
 
+#define MAJOR_VERSION_LENGTH 8
+
 void nr_php_framework_add_supportability_metric(const char* framework_name,
                                                 const char* name TSRMLS_DC) {
   char buf[512];
@@ -62,13 +64,13 @@ void nr_fw_support_add_package_supportability_metric(
   }
 
   char* metname = NULL;
-  char major_version[5] = {0};
+  char major_version[MAJOR_VERSION_LENGTH] = {0};
 
   /* The below for loop checks if the major version of the package is more than
    * one digit and keeps looping until a '.' is encountered or one of the
    * conditions is met.
    */
-  for (int i = 0; package_version[i] && i < 4; i++) {
+  for (int i = 0; package_version[i] && i < MAJOR_VERSION_LENGTH - 1; i++) {
     if ('.' == package_version[i]) {
       break;
     }

diff --git a/agent/lib_monolog.c b/agent/lib_monolog.c
@@ -31,6 +31,7 @@
   "newrelic_phpagent_monolog_decorating_processor"
 
 #define PHP_PACKAGE_NAME "monolog/monolog"
+#define MAJOR_VERSION_LENGTH 8
 
 /*
  * Purpose : Convert Monolog\Logger::API to integer
@@ -375,7 +376,7 @@ NR_PHP_WRAPPER(nr_monolog_logger_addrecord) {
     api = nr_monolog_version(this_var TSRMLS_CC);
     timestamp
         = nr_monolog_get_timestamp(api, argc, NR_EXECUTE_ORIG_ARGS TSRMLS_CC);
-    char version[5];
+    char version[MAJOR_VERSION_LENGTH];
     snprintf(version, sizeof(version), "%d", api);
     nr_fw_support_add_package_supportability_metric(NRPRG(txn),
                                                     PHP_PACKAGE_NAME, version);