fix(tests): Enhances error trace inspection for linking

Adds test to check the "guid" intrinsics attribute in addition to the "CatsGuid" field.
newrelic · Mar 5, 2024 · 7eabda6 · 7eabda6
1 parent 711a5e8
commit 7eabda6
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 3 deletions.
diff --git a/tests/integration/errors/test_error_linking_dt_off_cat_off.php b/tests/integration/errors/test_error_linking_dt_off_cat_off.php
@@ -45,6 +45,15 @@
 ]
 */
 
+
+/*EXPECT
+ok - Error trace payload length
+ok - Error trace CatsGUID is txn guid
+ok - Error trace contains intrinsics
+ok - Error trace intrinsics contains guid
+ok - Error trace intrisics guid is txn guid
+*/
+
 require_once(realpath (dirname ( __FILE__ )) . '/../../include/tap.php');
 
 function throw_it() {
@@ -56,5 +65,17 @@ function throw_it() {
 /* capture error trace json and verify transaction GUID */
 $json = newrelic_get_error_json();
 $payload = json_decode($json, true);
+
 $guid = newrelic_get_transaction_guid();
-tap_equal($guid, $payload[5], "Error trace includes txn guid");
+
+tap_equal(6, count($payload), "Error trace payload length");
+
+$catsguid = $payload[5];
+tap_equal($guid, $catsguid, "Error trace CatsGUID is txn guid");
+
+tap_assert(array_key_exists("intrinsics", $payload[4]), "Error trace contains intrinsics");
+
+$intrinsics = $payload[4]["intrinsics"];
+
+tap_assert(array_key_exists("guid", $intrinsics), "Error trace intrinsics contains guid");
+tap_equal($guid, $intrinsics["guid"], "Error trace intrisics guid is txn guid");
diff --git a/tests/integration/errors/test_error_linking_dt_off_cat_on.php b/tests/integration/errors/test_error_linking_dt_off_cat_on.php
@@ -45,6 +45,14 @@
 ]
 */
 
+/*EXPECT
+ok - Error trace payload length
+ok - Error trace CatsGUID is txn guid
+ok - Error trace contains intrinsics
+ok - Error trace intrinsics contains guid
+ok - Error trace intrisics guid is txn guid
+*/
+
 require_once(realpath (dirname ( __FILE__ )) . '/../../include/tap.php');
 
 function throw_it() {
@@ -56,5 +64,17 @@ function throw_it() {
 /* capture error trace json and verify transaction GUID */
 $json = newrelic_get_error_json();
 $payload = json_decode($json, true);
+
 $guid = newrelic_get_transaction_guid();
-tap_equal($guid, $payload[5], "Error trace includes txn guid");
+
+tap_equal(6, count($payload), "Error trace payload length");
+
+$catsguid = $payload[5];
+tap_equal($guid, $catsguid, "Error trace CatsGUID is txn guid");
+
+tap_assert(array_key_exists("intrinsics", $payload[4]), "Error trace contains intrinsics");
+
+$intrinsics = $payload[4]["intrinsics"];
+
+tap_assert(array_key_exists("guid", $intrinsics), "Error trace intrinsics contains guid");
+tap_equal($guid, $intrinsics["guid"], "Error trace intrisics guid is txn guid");
diff --git a/tests/integration/errors/test_error_linking_dt_on_cat_off.php b/tests/integration/errors/test_error_linking_dt_on_cat_off.php
@@ -45,6 +45,14 @@
 ]
 */
 
+/*EXPECT
+ok - Error trace payload length
+ok - Error trace CatsGUID is txn guid
+ok - Error trace contains intrinsics
+ok - Error trace intrinsics contains guid
+ok - Error trace intrisics guid is txn guid
+*/
+
 require_once(realpath (dirname ( __FILE__ )) . '/../../include/tap.php');
 
 function throw_it() {
@@ -56,5 +64,20 @@ function throw_it() {
 /* capture error trace json and verify transaction GUID */
 $json = newrelic_get_error_json();
 $payload = json_decode($json, true);
+
 $guid = newrelic_get_transaction_guid();
-tap_equal($guid, $payload[5], "Error trace includes txn guid");
+
+tap_equal(6, count($payload), "Error trace payload length");
+
+$catsguid = $payload[5];
+tap_equal($guid, $catsguid, "Error trace CatsGUID is txn guid");
+
+tap_assert(array_key_exists("intrinsics", $payload[4]), "Error trace contains intrinsics");
+
+$intrinsics = $payload[4]["intrinsics"];
+
+tap_assert(array_key_exists("guid", $intrinsics), "Error trace intrinsics contains guid");
+tap_equal($guid, $intrinsics["guid"], "Error trace intrisics guid is txn guid");
+
+
+