Skip to content

Commit

Permalink
ci: make test-pull-request more useful (#711)
Browse files Browse the repository at this point in the history
1. Don't cancel all in-progress and queued integration tests jobs if one of
them fails.

2. Test all pull requests targeting any branch, not only targeting `main`,
`dev` and `oapi` branches.

3. There's no need to enable arm64 emulation when not testing arm64 agent.
Use the right way to enable arm64.
  • Loading branch information
lavarou authored Aug 14, 2023
1 parent 5c29b98 commit dfb359f
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/test-agent.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,9 @@ on:
branches:
- main
- 'dev'
# trigger job for each pull request, regardless of the target branch
pull_request:
branches:
- main
- 'dev'
- 'oapi'

jobs:
daemon-unit-tests:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -96,8 +94,11 @@ jobs:
with:
path: php-agent
- name: Enable arm64 emulation
run: |
docker run --privileged --rm tonistiigi/binfmt --install arm64
if: ${{ matrix.arch == 'arm64' }}
uses: docker/setup-qemu-action@v2
with:
image: tonistiigi/binfmt:${{vars.BINFMT_IMAGE_VERSION}}
platforms: arm64
- name: Login to Docker Hub
uses: docker/login-action@v2
with:
Expand Down Expand Up @@ -159,6 +160,7 @@ jobs:
needs: [daemon-unit-tests, agent-unit-test]
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
platform: [gnu, musl]
arch: [amd64, arm64]
Expand Down

0 comments on commit dfb359f

Please sign in to comment.