Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newrelic-install): include link to docs in install error message #686

Closed
wants to merge 1 commit into from

Conversation

kidk
Copy link
Contributor

@kidk kidk commented Jun 23, 2023

When installing the agent on unsupported version of php on specific arch, include link to docs in the error message. Small output change as I personally got stuck here. The other output on incompatibility always include the link so I copied it into this error message.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2023

CLA assistant check
All committers have signed the CLA.

@kidk kidk force-pushed the sv-docs-unsupported-arch branch from 49be115 to 21543cf Compare June 26, 2023 11:55
@kidk kidk changed the base branch from main to dev June 26, 2023 11:56
@lavarou lavarou changed the title chore: added link to requirements on unsupported version of php on specific arch feat(newrelic-install): include link to docs in install error message Jul 12, 2023
@bduranleau-nr
Copy link
Contributor

Hi @kidk - our CI/CD is failing due to the branch for this PR being on a fork of the repo. By default we don't allow CI/CD workflows to run from forks due to security concerns- are you able to create a branch directly in the repo itself and create a PR based on that?

@kidk
Copy link
Contributor Author

kidk commented Jul 26, 2023

@bduranleau-nr

ERROR: Permission to newrelic/newrelic-php-agent.git denied to kidk.
fatal: Could not read from remote repository.

I don't have the permissions to do so.

@bduranleau-nr
Copy link
Contributor

@kidk - closing this as we've migrated the PR over to #702 in order to get the CI/CD to run.

@kidk
Copy link
Contributor Author

kidk commented Jul 27, 2023

Awesome thanks @bduranleau-nr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants