ci: refactor run-integration-tests to use larger runners #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor into reusable workflows. This allows to fine tune which runners to use for which architecture.
lavarou
requested review from
ZNeumann,
zsistla,
mfulb,
bduranleau-nr and
hahuja2
lavarou
force-pushed
the
ci/large-runners-experiment
branch
from
4d57318
to
ac91e97
Compare
bduranleau-nr
approved these changes
Jul 28, 2023
ZNeumann
approved these changes
Jul 31, 2023
hahuja2
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor run-integration-tests workflow into reusable workflows to allow fine tuning which runners to use for which job depending on architecture. Experiments showed that building on default runner but using larger runner (4cores) for running integration tests on arm64 achieves best time/cost results. I.e. using larger runners to build on arm64 cuts the workflow runtime from about 30 minutes to about 20 minutes and therefore does not seem necessary. However, using larger runners to run test on arm64 is necessary not as much for time savings but for performance - without larger runners, tests run too slow and more spans are captured which causes actual results not to match test expectations.