-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(axiom): handle locale for dt w3c priority #828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavarou
reviewed
Feb 6, 2024
lavarou
reviewed
Feb 6, 2024
Co-authored-by: Michal Nowacki <[email protected]>
Co-authored-by: Michal Nowacki <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #828 +/- ##
==========================================
- Coverage 78.74% 78.69% -0.06%
==========================================
Files 189 191 +2
Lines 26370 26599 +229
==========================================
+ Hits 20766 20933 +167
- Misses 5604 5666 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
reviewed
Feb 7, 2024
Co-authored-by: Michal Nowacki <[email protected]>
lavarou
reviewed
Feb 7, 2024
lavarou
reviewed
Feb 7, 2024
lavarou
reviewed
Feb 7, 2024
Co-authored-by: Michal Nowacki <[email protected]>
mfulb
reviewed
Feb 8, 2024
mfulb
reviewed
Feb 8, 2024
mfulb
reviewed
Feb 8, 2024
ZNeumann
approved these changes
Feb 8, 2024
this will have to be added back later once compiled locales are integrated into the upstream builder images
mfulb
approved these changes
Feb 8, 2024
lavarou
reviewed
Feb 8, 2024
lavarou
reviewed
Feb 8, 2024
lavarou
reviewed
Feb 8, 2024
lavarou
reviewed
Feb 8, 2024
Co-authored-by: Michal Nowacki <[email protected]>
Co-authored-by: Michal Nowacki <[email protected]>
Co-authored-by: Michal Nowacki <[email protected]>
lavarou
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for locale differences when generating the DT w3c tracestate header.
Mitigates a risk against unexpected locale settings using
,
rather than.
for the decimal priority value breaking the PHP Agent's DT w3c handling.