Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axiom): handle locale for dt w3c priority #828

Merged
merged 24 commits into from
Feb 8, 2024
Merged

Conversation

bduranleau-nr
Copy link
Contributor

Account for locale differences when generating the DT w3c tracestate header.
Mitigates a risk against unexpected locale settings using , rather than . for the decimal priority value breaking the PHP Agent's DT w3c handling.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (bf0223c) 78.74% compared to head (d1110c5) 78.69%.
Report is 8 commits behind head on dev.

Files Patch % Lines
axiom/nr_distributed_trace.c 80.00% 3 Missing ⚠️
agent/php_nrini.c 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #828      +/-   ##
==========================================
- Coverage   78.74%   78.69%   -0.06%     
==========================================
  Files         189      191       +2     
  Lines       26370    26599     +229     
==========================================
+ Hits        20766    20933     +167     
- Misses       5604     5666      +62     
Flag Coverage Δ
agent-for-php-7.0 77.55% <80.00%> (-0.05%) ⬇️
agent-for-php-7.1 77.28% <79.16%> (-0.06%) ⬇️
agent-for-php-7.2 77.85% <79.16%> (-0.05%) ⬇️
agent-for-php-7.3 77.87% <79.16%> (-0.05%) ⬇️
agent-for-php-7.4 77.53% <79.16%> (-0.05%) ⬇️
agent-for-php-8.0 77.63% <79.16%> (-0.05%) ⬇️
agent-for-php-8.1 77.59% <79.16%> (-0.05%) ⬇️
agent-for-php-8.2 77.37% <79.16%> (-0.05%) ⬇️
agent-for-php-8.3 77.37% <79.16%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bduranleau-nr bduranleau-nr added this to the 10.17.0 milestone Feb 7, 2024
axiom/nr_txn.c Outdated Show resolved Hide resolved
axiom/util_number_converter.c Outdated Show resolved Hide resolved
axiom/util_number_converter.c Outdated Show resolved Hide resolved
@bduranleau-nr bduranleau-nr merged commit 4746cca into dev Feb 8, 2024
61 checks passed
@bduranleau-nr bduranleau-nr deleted the w3c-dt-improvements branch February 8, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants