Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): Add supportability metrics for packages that provide major version #868

Merged
merged 21 commits into from
Apr 19, 2024

Conversation

hahuja2
Copy link
Contributor

@hahuja2 hahuja2 commented Mar 27, 2024

This PR creates a new supportability metric that will provide information on what major version of the package is being used. The packages that provide the major version and will send up this supportability metric are:

  • Drupal
  • Guzzle
  • Laravel
  • Monolog
  • Predis
  • Slim
  • Wordpress.

@mfulb
Copy link
Contributor

mfulb commented Mar 28, 2024

I think all versions of Guzzle and Monolog will give you a major version. Probably other frameworks potentially will give us just major info.

agent/fw_drupal8.c Outdated Show resolved Hide resolved
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Mar 29, 2024

Test Suite Status Result
Multiverse 0/9 passing
SOAK 51/51 passing

@hahuja2
Copy link
Contributor Author

hahuja2 commented Mar 29, 2024

I think all versions of Guzzle and Monolog will give you a major version.

Good point, I have added supportability metrics for Guzzle and Monolog by major version also: 5248b97

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 78.73%. Comparing base (1717ca9) to head (55c1e1e).
Report is 4 commits behind head on dev.

Files Patch % Lines
agent/fw_slim.c 0.00% 5 Missing ⚠️
agent/fw_drupal8.c 25.00% 3 Missing ⚠️
agent/fw_wordpress.c 25.00% 3 Missing ⚠️
agent/fw_laravel.c 0.00% 2 Missing ⚠️
agent/php_agent.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #868      +/-   ##
==========================================
- Coverage   78.76%   78.73%   -0.04%     
==========================================
  Files         193      193              
  Lines       27125    27154      +29     
==========================================
+ Hits        21365    21379      +14     
- Misses       5760     5775      +15     
Flag Coverage Δ
agent-for-php-7.0 77.46% <45.65%> (-0.36%) ⬇️
agent-for-php-7.1 77.22% <45.65%> (?)
agent-for-php-7.2 78.15% <69.56%> (+<0.01%) ⬆️
agent-for-php-7.3 78.17% <69.56%> (+<0.01%) ⬆️
agent-for-php-7.4 77.87% <69.56%> (+<0.01%) ⬆️
agent-for-php-8.0 77.90% <69.56%> (+<0.01%) ⬆️
agent-for-php-8.1 77.88% <69.56%> (+<0.01%) ⬆️
agent-for-php-8.2 77.48% <69.56%> (+<0.01%) ⬆️
agent-for-php-8.3 77.48% <69.56%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

agent/fw_support.c Outdated Show resolved Hide resolved
agent/fw_laravel.c Outdated Show resolved Hide resolved
agent/fw_slim.c Outdated Show resolved Hide resolved
agent/fw_wordpress.c Outdated Show resolved Hide resolved
Copy link
Contributor

@mfulb mfulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hahuja2 hahuja2 merged commit 5b964b4 into dev Apr 19, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants