Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): Add additional custom error handler tests #869

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

zsistla
Copy link
Contributor

@zsistla zsistla commented Mar 29, 2024

Added additional tests to exercise a variety of return values from a custom error handler.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Mar 29, 2024

Test Suite Status Result
Multiverse 9/9 passing

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (6def121) to head (a272070).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #869   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         193      193           
  Lines       27125    27125           
=======================================
  Hits        21365    21365           
  Misses       5760     5760           
Flag Coverage Δ
agent-for-php-7.0 77.82% <ø> (ø)
agent-for-php-7.1 77.58% <ø> (ø)
agent-for-php-7.2 78.15% <ø> (ø)
agent-for-php-7.3 78.17% <ø> (ø)
agent-for-php-7.4 77.87% <ø> (ø)
agent-for-php-8.0 77.90% <ø> (ø)
agent-for-php-8.1 77.88% <ø> (ø)
agent-for-php-8.2 77.48% <ø> (ø)
agent-for-php-8.3 77.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Certain scenarios are only errors with PHP8.
Copy link
Member

@lavarou lavarou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

@zsistla zsistla merged commit 06d0436 into dev Apr 5, 2024
62 checks passed
@zsistla zsistla deleted the error_handler_tests branch September 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants