Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(daemon): fix json struct tag for docker id #870

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix(daemon): fix json struct tag for docker id #870

merged 1 commit into from
Apr 5, 2024

Conversation

bduranleau-nr
Copy link
Contributor

No description provided.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Mar 29, 2024 •
edited
Loading

Test Suite Status Result
Multiverse ✅ 9/9 passing
SOAK ❌ 50/51 passing

@zsistla
Copy link
Contributor

zsistla commented Apr 5, 2024

Are there tests that exercise this functionality?

@bduranleau-nr
Copy link
Contributor Author

Are there tests that exercise this functionality?

Yes. See the tests added in the original PR and the pre-existing tests for marshalling this data.

@bduranleau-nr bduranleau-nr merged commit e0d2d12 into dev Apr 5, 2024
62 checks passed
@bduranleau-nr bduranleau-nr deleted the fix/docker-id-json-tag branch April 5, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZNeumann ZNeumann ZNeumann approved these changes

@zsistla zsistla zsistla approved these changes

@lavarou lavarou lavarou approved these changes

@mfulb mfulb Awaiting requested review from mfulb

@hahuja2 hahuja2 Awaiting requested review from hahuja2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bduranleau-nr @newrelic-php-agent-bot @zsistla @ZNeumann @lavarou