Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Fix error reporting when EH_THROW is enabled #876

Merged
merged 11 commits into from
Apr 18, 2024
Merged

Commits on Apr 11, 2024

  1. fix(agent): Fix error reporting when EH_THROW is enabled

      /*
       * For a the following error codes:
       * E_WARNING || E_CORE_WARNING || E_COMPILE_WARNING || E_USER_WARNING
       * PHP triggers an exception if EH_THROW is toggled on and then immediately
       * returns after throwing the exception. See for more info:
       * https://github.com/php/php-src/blob/master/main/main.c In that case, we
       * should not handle it, but we should exist and let the exception handler
       * deal with it; otherwise, we could record an error even if an exception is
       * caught.
       */
    zsistla committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7d8b174 View commit details
    Browse the repository at this point in the history
  2. fix(agent): Fix error reporting when EH_THROW is enabled

      /*
       * For a the following error codes:
       * E_WARNING || E_CORE_WARNING || E_COMPILE_WARNING || E_USER_WARNING
       * PHP triggers an exception if EH_THROW is toggled on and then immediately
       * returns after throwing the exception. See for more info:
       * https://github.com/php/php-src/blob/master/main/main.c In that case, we
       * should not handle it, but we should exist and let the exception handler
       * deal with it; otherwise, we could record an error even if an exception is
       * caught.
       */
    zsistla committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0db7169 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Update agent/php_error.c

    Co-authored-by: ZNeumann <[email protected]>
    zsistla and ZNeumann authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1c6ebdc View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    cb7d58a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48c0cb0 View commit details
    Browse the repository at this point in the history
  3. Update agent/php_error.c

    Co-authored-by: Michal Nowacki <[email protected]>
    zsistla and lavarou authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0c30c43 View commit details
    Browse the repository at this point in the history
  4. Update tests/integration/errors/test_EH_THROW_errors_caught_exception…

    ….php
    
    Co-authored-by: Michal Nowacki <[email protected]>
    zsistla and lavarou authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    eabce3b View commit details
    Browse the repository at this point in the history
  5. Update tests/integration/errors/test_EH_THROW_errors_uncaught_excepti…

    …on.php
    
    Co-authored-by: Michal Nowacki <[email protected]>
    zsistla and lavarou authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    98febf4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed0456a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cc91192 View commit details
    Browse the repository at this point in the history
  8. Update agent/php_error.c

    Co-authored-by: Michal Nowacki <[email protected]>
    zsistla and lavarou authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    49ee178 View commit details
    Browse the repository at this point in the history