-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agent): fix mongodb instrumentation for PHP 8.0+ #878
Conversation
bduranleau-nr
commented
Apr 15, 2024
•
edited
Loading
edited
- split mongodb instrumentation into before/after inline with OAPI paradigm.
- remove broken integration tests in favor of Multiverse tests
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #878 +/- ##
======================================
Coverage ? 78.57%
======================================
Files ? 193
Lines ? 27290
Branches ? 0
======================================
Hits ? 21443
Misses ? 5847
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
19c39de
to
64c6306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f3164c6
to
6f0d244
Compare
due to mongodb library changes, it has become infeasible to run integration tests. replace with Multiverse tests instead.
a163988
to
eaff30f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job getting this working.