Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): fix mongodb instrumentation for PHP 8.0+ #878

Merged
merged 11 commits into from
Jun 21, 2024

Conversation

bduranleau-nr
Copy link
Contributor

@bduranleau-nr bduranleau-nr commented Apr 15, 2024

  • split mongodb instrumentation into before/after inline with OAPI paradigm.
  • remove broken integration tests in favor of Multiverse tests

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Apr 15, 2024

Test Suite Status Result
Multiverse / passing
SOAK / passing

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@756c1aa). Learn more about missing BASE report.

Files Patch % Lines
agent/lib_mongodb.c 0.00% 54 Missing ⚠️
agent/php_wrapper.c 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #878   +/-   ##
======================================
  Coverage       ?   78.57%           
======================================
  Files          ?      193           
  Lines          ?    27290           
  Branches       ?        0           
======================================
  Hits           ?    21443           
  Misses         ?     5847           
  Partials       ?        0           
Flag Coverage Δ
agent-for-php-7.0 77.49% <0.00%> (?)
agent-for-php-7.1 77.24% <0.00%> (?)
agent-for-php-7.2 78.16% <0.00%> (?)
agent-for-php-7.3 78.18% <0.00%> (?)
agent-for-php-7.4 77.89% <0.00%> (?)
agent-for-php-8.0 77.92% <0.00%> (?)
agent-for-php-8.1 77.90% <0.00%> (?)
agent-for-php-8.2 77.50% <0.00%> (?)
agent-for-php-8.3 77.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bduranleau-nr bduranleau-nr marked this pull request as ready for review April 16, 2024 15:34
@ZNeumann ZNeumann changed the title fix: update mongodb instrumentation with oapi paradigm fix: update mongodb library instrumentation with oapi paradigm Apr 16, 2024
agent/lib_mongodb.c Outdated Show resolved Hide resolved
agent/lib_mongodb.c Outdated Show resolved Hide resolved
@lavarou lavarou changed the title fix: update mongodb library instrumentation with oapi paradigm fix(agent): fix mongodb instrumentation for PHP 8.0+ May 8, 2024
agent/php_wrapper.c Outdated Show resolved Hide resolved
agent/lib_mongodb.c Outdated Show resolved Hide resolved
Copy link
Member

@lavarou lavarou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lavarou lavarou added this to the next-release milestone Jun 20, 2024
lavarou
lavarou previously approved these changes Jun 21, 2024
agent/lib_mongodb.c Outdated Show resolved Hide resolved
agent/lib_mongodb.c Outdated Show resolved Hide resolved
Copy link
Contributor

@zsistla zsistla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job getting this working.

@bduranleau-nr bduranleau-nr merged commit a8663c7 into dev Jun 21, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants