Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): update default for wp hooks options #880

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Apr 19, 2024

By default the agent will only instrument hook callbacks from plugins/themes and will not instrument hook callbacks from wordpress core.

@lavarou lavarou added this to the next-release milestone Apr 19, 2024
@lavarou lavarou self-assigned this Apr 19, 2024
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Apr 19, 2024

Test Suite Status Result
Multiverse 9/9 passing
SOAK 56/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (5b964b4) to head (e0ff77b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #880   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         193      193           
  Lines       27204    27204           
=======================================
  Hits        21410    21410           
  Misses       5794     5794           
Flag Coverage Δ
agent-for-php-7.0 77.43% <ø> (ø)
agent-for-php-7.1 77.19% <ø> (ø)
agent-for-php-7.2 78.11% <ø> (ø)
agent-for-php-7.3 78.13% <ø> (ø)
agent-for-php-7.4 77.84% <ø> (ø)
agent-for-php-8.0 77.90% <ø> (ø)
agent-for-php-8.1 77.89% <ø> (ø)
agent-for-php-8.2 77.49% <ø> (ø)
agent-for-php-8.3 77.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou marked this pull request as ready for review April 19, 2024 19:12
By default the agent will only instrument hook callbacks from plugins/themes
and will not instrument hook callbacks from wordpress core.
@lavarou lavarou force-pushed the feat/agent/update-wp-hooks-options-default branch from 30747ff to 4e99b9b Compare April 19, 2024 19:14
@lavarou lavarou requested a review from mfulb April 19, 2024 20:15
@lavarou lavarou merged commit 7c985b8 into dev Apr 23, 2024
62 checks passed
@lavarou lavarou deleted the feat/agent/update-wp-hooks-options-default branch April 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants