chore(agent): cleanup agent's verbosedebug log #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't print `Stack depth: ...` messages unless requested with newrelic.special show_execute_stack_depth.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #896 +/- ##
=======================================
Coverage 78.78% 78.79%
=======================================
Files 193 193
Lines 27216 27214 -2
=======================================
Hits 21443 21443
+ Misses 5773 5771 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zsistla
reviewed
May 14, 2024
Change of strategy: don't print `Stack depth: ...` messages. Stack depth can can be inferred from the level of indentation used in `nr_php_show_exec` and `nr_php_show_exec_return` - both use `nr_php_show_exec_indentation`, which uses `NRPRG(php_cur_stack_depth)` to calculate indentation level.
zsistla
approved these changes
May 14, 2024
ZNeumann
approved these changes
May 15, 2024
lavarou
added a commit
that referenced
this pull request
Aug 2, 2024
Don't print `Stack depth: ...` messages. Stack depth can be inferred from the level of indentation used in `nr_php_show_exec` and `nr_php_show_exec_return` - both use `nr_php_show_exec_indentation`, which uses `NRPRG(php_cur_stack_depth)` to calculate indentation level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't print
Stack depth: ...messages. Stack depth cancan be inferred from the level of indentation used in
nr_php_show_execandnr_php_show_exec_return- both usenr_php_show_exec_indentation, whichuses
NRPRG(php_cur_stack_depth)to calculate indentation level.