fix(installer): better handle systemd installations #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ZNeumann
commented
Jun 3, 2024
zsistla
approved these changes
Jun 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #910 +/- ##
=======================================
Coverage 78.79% 78.79%
=======================================
Files 193 193
Lines 27214 27214
=======================================
Hits 21443 21443
Misses 5771 5771
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
reviewed
Jun 7, 2024
Comment on lines
+855
to
+856
| if [ -n "${NR_INSTALL_INITSCRIPT}" ]; then | ||
| osdifile="${NR_INSTALL_INITSCRIPT}" |
There was a problem hiding this comment.
These changes have been incorporated in #913.
lavarou
reviewed
Jun 7, 2024
| fi | ||
| if [ "${ostype}" = "darwin" ]; then | ||
| : ${osdifile:=/usr/bin/newrelic-daemon-service} | ||
| elif [ "${ostype}" = "freebsd" -o -f /etc/arch-release ]; then | ||
| # It is possible that this is only for freebsd. | ||
| elif [ -f /etc/arch-release -o -d /etc/rc.d ]; then |
There was a problem hiding this comment.
#913 addresses this problem in a more universal way applicable to wider group of OSs.
|
superseded by #913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systemd is an alternative solution to the init scripts in init.d.