Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent): Slim txn naming updates #917

Merged
merged 5 commits into from
Jun 14, 2024
Merged

fix(agent): Slim txn naming updates #917

merged 5 commits into from
Jun 14, 2024

Commits on Jun 13, 2024

  1. fix(agent): Slim txn naming updates 

    1) the scheme for route run to correlate with proper OAPI naming was incorrectly listed
2) kept same naming scheme in route:run by putting it before wrapper_call and saying ok to overwrite
3) number 2 needed to incorporate fallback naming scheme
4) added fallback naming scheme (since some errors and middleware intervention hides the txn name) using dispatcher:dispatch.

When there is an exception thrown in a route that is handled by the slim routing and error middleware, it is superseded by:
Uncaught exception 'Slim\\Exception\\HttpNotFoundException' with message 'Not found.' and transformed into an http 404 error and is shown in the http.statuscode field as 404.  If the middleware isn't loaded, it is recorded as an uncaught exception and status code is 200.

Wrap function Slim\\Routing\\Dispatcher::dispatch
It will name set the txn_name in case we hit an error and Slim\\Routing\\Route::run isn't called.  It is set to be overwritable do that if we encounter Slim\\Routing\\Route::run, it can overwrite with the most accurate info (this is only relevant in the case of redirects).  This allows us to give the txn_name even in error cases when Slim\\Routing\\Route::run isn't called.
    @zsistla
    zsistla committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    b30ce13 View commit details
    Browse the repository at this point in the history

  2. fix(agent): Fix comment.

    @zsistla
    zsistla committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3ac4075 View commit details
    Browse the repository at this point in the history

  3. Update agent/fw_slim.c 

    Co-authored-by: Michal Nowacki <[email protected]>
    @zsistla @lavarou
    zsistla and lavarou authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3197445 View commit details
    Browse the repository at this point in the history

  4. fix(agent): comment fix

    @zsistla
    zsistla committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2e35374 View commit details
    Browse the repository at this point in the history

  5. Update agent/fw_slim.c 

    Co-authored-by: Michal Nowacki <[email protected]>
    @zsistla @lavarou
    zsistla and lavarou authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3ce2a70 View commit details
    Browse the repository at this point in the history