refactor(agent): improve magic file recognition performance #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed up magic file recognition performance by cleaning up the list of magic files from the files that belong to uninstrumented packages.
Remove files that belong to old and uninstrumented frameworks/libraries from `libraries` and `logging_frameworks` arrays.
|
After `logging_frameworks` cleanup, the agent no longer detects `cakephp/log` or `analog/analog` - the tests need to be removed as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #975 +/- ##
=======================================
Coverage 78.54% 78.54%
=======================================
Files 196 196
Lines 27103 27103
=======================================
Hits 21287 21287
Misses 5816 5816
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zsistla
approved these changes
Oct 15, 2024
lavarou
deleted the
refactor/improve-magic-file-recognition-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up magic file recognition performance by cleaning up the list of magic
files from the files that belong to uninstrumented packages.