Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance dockerized development environment #977

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Oct 16, 2024

  1. Add an option to control which PHP version is to be used in devenv service
    via PHP env var passed at the time when dev-shell is started (or any dev-*
    target is build).

  2. Simplify composer and go install.

  3. Fix devenv service image build for PHPs 7.2 and 7.3.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Oct 16, 2024

Test Suite Status Result
Multiverse 0/7 passing
SOAK 56/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.54%. Comparing base (727812d) to head (7cd21b6).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #977   +/-   ##
=======================================
  Coverage   78.54%   78.54%           
=======================================
  Files         196      196           
  Lines       27103    27103           
=======================================
  Hits        21287    21287           
  Misses       5816     5816           
Flag Coverage Δ
agent-for-php-7.2 78.55% <ø> (ø)
agent-for-php-7.3 78.57% <ø> (ø)
agent-for-php-7.4 78.27% <ø> (ø)
agent-for-php-8.0 78.29% <ø> (ø)
agent-for-php-8.1 78.28% <ø> (ø)
agent-for-php-8.2 77.87% <ø> (ø)
agent-for-php-8.3 77.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Use `docker compose exec` instead of `docker exec` to make sure that
Development Environment commands execute in the correct container, even
when multiple Development Environment are running simultanously.
Add an option to control which PHP version is to be used in devenv service
via PHP env var passed at the time when dev-shell is started (or any dev-*
target is build).
Dockerfile's COPY instruction supports copying from another image. This
feature simplifies composer installation significantly because composer
can simply be copied over from official image rather than programatically
installed.
Install `redis` extension, required by test_redis, in correct version.
Install `argon2` and `libghc-argon2-dev` for all PHPs but don't install
`python-dev-is-python3` for PHP 7.2 where the debian version is 10 buster.
Dockerfile's COPY instruction supports copying from another image. This
feature simplifies golang installation significantly because golang
can simply be copied over from official image rather than programatically
installed. This ensures that the latest version of go for the correct
platform will always be installed.
@lavarou lavarou self-assigned this Oct 28, 2024
@lavarou lavarou marked this pull request as ready for review October 28, 2024 22:15
@lavarou lavarou requested a review from ZNeumann October 28, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants