-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add quickstart for browser marks and measures #2618
feat: Add quickstart for browser marks and measures #2618
Conversation
The PR checks have run and found the following warnings:
Reference the Contributing Docs for Dashboards for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @metal-messiah, could you please make the review changes.
- Is it possible to add alerts to this quickstart? It's considered best practice.
- I noticed that the dashboard chart titles are not in sentence case. It's recommended to use sentence case for them, e.g.,
Marks Observed
should beMarks observed
.
Co-authored-by: RamanaReddy8801 <[email protected]>
Co-authored-by: RamanaReddy8801 <[email protected]>
Co-authored-by: RamanaReddy8801 <[email protected]>
Co-authored-by: RamanaReddy8801 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dashboards/browser-marks-and-measures/browser-marks-and-measures.json
Outdated
Show resolved
Hide resolved
I have applied the name changes in the dashboard JSON. As far as alerts, this is non-specific generic data, tied directly to customer implementation patterns. We wont be able to provide meaningful alert conditions on this data, that would be up to the customer to make it fit their definition of their generic dataset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @metal-messiah,
I noticed the addition of the browser-page-resources
quickstart dashboard JSON in this PR. Could you clarify the reason for including it? If it was added by mistake, could you please remove the browser-page-resources
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
This adds a quickstart showing usage of new marks and measures, and links to documentation to get that feature enabled.
Pre merge checklist
Dashboards