Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add quickstart for browser marks and measures #2618

Merged
merged 11 commits into from
Feb 5, 2025

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Jan 22, 2025

Summary

This adds a quickstart showing usage of new marks and measures, and links to documentation to get that feature enabled.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

The PR checks have run and found the following warnings:

Warning Filepath
"permissions" field should not be used dashboards/browser-marks-and-measures/browser-marks-and-measures.json

Reference the Contributing Docs for Dashboards for more information.

@metal-messiah metal-messiah changed the title Add quickstart for browser marks and measures feat: Add quickstart for browser marks and measures Jan 22, 2025
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metal-messiah, could you please make the review changes.

  1. Is it possible to add alerts to this quickstart? It's considered best practice.
  2. I noticed that the dashboard chart titles are not in sentence case. It's recommended to use sentence case for them, e.g., Marks Observed should be Marks observed.

sjyothi54
sjyothi54 previously approved these changes Jan 30, 2025
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal-messiah
Copy link
Member Author

Hi @RamanaReddy8801

I have applied the name changes in the dashboard JSON. As far as alerts, this is non-specific generic data, tied directly to customer implementation patterns. We wont be able to provide meaningful alert conditions on this data, that would be up to the customer to make it fit their definition of their generic dataset.

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metal-messiah,

I noticed the addition of the browser-page-resources quickstart dashboard JSON in this PR. Could you clarify the reason for including it? If it was added by mistake, could you please remove the browser-page-resources folder?

Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkudikyala pkudikyala merged commit 7e7a84f into newrelic:release Feb 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants