fix: fix duplicate method issue

react native ios build is not compling because of duplicate method in ios module #141
newrelic · Jan 3, 2024 · 46405e5 · 46405e5
1 parent 6cd5b48
commit 46405e5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,17 @@
 # Changelog
 
+## 1.3.5
+
+### New in this release
+* Adds configurable request header instrumentation to network events
+The agent will now produce network event attributes for select header values if the headers are detected on the request. The header names to instrument are passed into the agent when started.
+* Updated the native Android agent to version 7.2.0.
+* Updated the native iOS agent to version 7.4.8.
+
 ## 1.3.4
 
+### Please refrain from using this release, as it encountered compilation errors during the iOS development process.
+
 ### New in this release
 * Adds configurable request header instrumentation to network events
 The agent will now produce network event attributes for select header values if the headers are detected on the request. The header names to instrument are passed into the agent when started.

diff --git a/NewRelicExampleApp/React-Native-Test-App/package.json b/NewRelicExampleApp/React-Native-Test-App/package.json
@@ -14,7 +14,7 @@
     "@react-navigation/native": "^6.1.6",
     "@react-navigation/native-stack": "^6.9.12",
     "moment": "^2.29.4",
-    "newrelic-react-native-agent": "1.3.3",
+    "newrelic-react-native-agent": "1.3.4",
     "react": "18.2.0",
     "react-native": "0.72.4",
     "react-native-safe-area-context": "^4.5.3",

diff --git a/ios/bridge/NRMModularAgent.m b/ios/bridge/NRMModularAgent.m
@@ -299,11 +299,6 @@ - (dispatch_queue_t)methodQueue{
     [NewRelic recordCustomEvent:eventType name:eventName attributes:attributes];
 }
 
-RCT_EXPORT_METHOD(addHTTPHeadersTrackingFor:(NSArray<NSString*> _Nonnull) headers) {
-    // todo: Not sure if we need to check the validity of these arguments at all..
-    [NewRelic addHTTPHeadersTrackingFor:headers];
-}
-
 /**
  * Track a method as an interaction
  */

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "newrelic-react-native-agent",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "description": "A New Relic Mobile Agent for React Native",
   "main": "./index.js",
   "types": "./dist/index.d.ts",