fix: update release tag name on pre-releases #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,3 +92,15 @@ jobs: | |||
| slack-bot-user-oauth-access-token: ${{ secrets.COREINT_SLACK_TOKEN }} | |||
| slack-channel: ${{ secrets.COREINT_SLACK_CHANNEL }} | |||
| slack-text: "❌ `${{ env.ORIGINAL_REPO_NAME }}`: [image release failed](${{ github.server_url }}/${{ env.ORIGINAL_REPO_NAME }}/actions/runs/${{ github.run_id }})." | |||
|
|
|||
| update-title-on-failure: | |||
There was a problem hiding this comment.
don't we need the same for release pipeline?
There was a problem hiding this comment.
Yes, it makes total sense
There was a problem hiding this comment.
I've just updated it here: e2ecfab.
I also considered using a GITHUB_ENV variable to compose the tittle but, I'm not sure if that would have been more complex. Let me know your thoughts.
There was a problem hiding this comment.
I think it is clear enough like this, it is just few lines below, therefore I think it is ok without jumping from one side to the other
paologallinaharbur
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the pre-release tag name when the pre-release success or fails