Skip to content

Commit

Permalink
Fix tests and formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
camdencheek committed Oct 28, 2019
1 parent b93477e commit 10abf31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/metric_definitions.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ func (mg *oracleMetricGroup) Collect(db *sql.DB, wg *sync.WaitGroup, metricChan

rows, err := db.Query(mg.sqlQuery())
if err != nil {
log.Error("Failed to execute query %s: %s", mg.sqlQuery(), err, db.Stats())
log.Debug("Database stats: %#v", db.Stats())
log.Error("Failed to execute query %s: %s", mg.sqlQuery(), err)
return
}
defer func() {
Expand Down
2 changes: 1 addition & 1 deletion src/oracledb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func TestGetCollectionString(t *testing.T) {
}

s := getConnectionString()
expectedConnectionString := `oracle://testuser:testpassword@testhost:/testservice?connectionClass=&poolIncrement=1&poolMaxSessions=0&poolMinSessions=1&sysdba=1&sysoper=0&standaloneConnection=0`
expectedConnectionString := `oracle://testuser:testpassword@testhost:/testservice?connectionClass=&poolIncrement=1&poolMaxSessions=0&poolMinSessions=0&sysdba=1&sysoper=0&standaloneConnection=0`

if s != expectedConnectionString {
t.Errorf("Incorrect connection string %s", s)
Expand Down

0 comments on commit 10abf31

Please sign in to comment.