Skip to content

Commit

Permalink
feat: add support for SERVICE_NOW_APP (#2693)
Browse files Browse the repository at this point in the history
  • Loading branch information
atkinchris authored Jul 17, 2024
1 parent 617d473 commit 3560052
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions newrelic/resource_newrelic_notifications_destination.go
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ func listValidNotificationsDestinationTypes() []string {
string(notifications.AiNotificationsDestinationTypeTypes.WEBHOOK),
string(notifications.AiNotificationsDestinationTypeTypes.EMAIL),
string(notifications.AiNotificationsDestinationTypeTypes.SERVICE_NOW),
string(notifications.AiNotificationsDestinationTypeTypes.SERVICE_NOW_APP),
string(notifications.AiNotificationsDestinationTypeTypes.PAGERDUTY_ACCOUNT_INTEGRATION),
string(notifications.AiNotificationsDestinationTypeTypes.PAGERDUTY_SERVICE_INTEGRATION),
string(notifications.AiNotificationsDestinationTypeTypes.JIRA),
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/notification_destination.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Optional:
In addition to all arguments above, the following attributes are exported:

* `name` - The name of the notification destination.
* `type` - The notification destination type, either: `EMAIL`, `SERVICE_NOW`, `WEBHOOK`, `JIRA`, `MOBILE_PUSH`, `EVENT_BRIDGE`, `PAGERDUTY_ACCOUNT_INTEGRATION` or `PAGERDUTY_SERVICE_INTEGRATION`, `SLACK` and `SLACK_COLLABORATION`.
* `type` - The notification destination type, either: `EMAIL`, `SERVICE_NOW`, `SERVICE_NOW_APP`, `WEBHOOK`, `JIRA`, `MOBILE_PUSH`, `EVENT_BRIDGE`, `PAGERDUTY_ACCOUNT_INTEGRATION` or `PAGERDUTY_SERVICE_INTEGRATION`, `SLACK` and `SLACK_COLLABORATION`.
* `property` - A nested block that describes a notification destination property.
* `active` - An indication whether the notification destination is active or not.
* `status` - The status of the notification destination.
Expand Down
4 changes: 3 additions & 1 deletion website/docs/r/notification_destination.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ The following arguments are supported:

* `account_id` - (Optional) Determines the New Relic account where the notification destination will be created. Defaults to the account associated with the API key used.
* `name` - (Required) The name of the destination.
* `type` - (Required) The type of destination. One of: `EMAIL`, `SERVICE_NOW`, `WEBHOOK`, `JIRA`, `MOBILE_PUSH`, `EVENT_BRIDGE`, `PAGERDUTY_ACCOUNT_INTEGRATION` or `PAGERDUTY_SERVICE_INTEGRATION`. The types `SLACK` and `SLACK_COLLABORATION` can only be imported, updated and destroyed (cannot be created via terraform).
* `type` - (Required) The type of destination. One of: `EMAIL`, `SERVICE_NOW`, `SERVICE_NOW_APP`, `WEBHOOK`, `JIRA`, `MOBILE_PUSH`, `EVENT_BRIDGE`, `PAGERDUTY_ACCOUNT_INTEGRATION` or `PAGERDUTY_SERVICE_INTEGRATION`. The types `SLACK` and `SLACK_COLLABORATION` can only be imported, updated and destroyed (cannot be created via terraform).
* `auth_basic` - (Optional) A nested block that describes a basic username and password authentication credentials. Only one auth_basic block is permitted per notification destination definition. See [Nested auth_basic blocks](#nested-auth_basic-blocks) below for details.
* `auth_token` - (Optional) A nested block that describes a token authentication credentials. Only one auth_token block is permitted per notification destination definition. See [Nested auth_token blocks](#nested-auth_token-blocks) below for details.
* `auth_custom_header` - (Optional) A nested block that describes a custom header authentication credentials. Multiple blocks are permitted per notification destination definition. [Nested auth_custom_header blocks](#nested-authcustomheader-blocks) below for details.
Expand Down Expand Up @@ -88,6 +88,8 @@ Each notification destination type supports a specific set of arguments for the
* `SERVICE_NOW`
* `url` - (Required) The service now destination url (only base url).
* `two_way_integration` - (Optional) A boolean that represents the two-way integration on/off flag.
* `SERVICE_NOW_APP`
* `url` - (Required) The service now destination url (only base url).
* `JIRA`
* `url` - (Required) The jira url (only base url).
* `two_way_integration` - (Optional) A boolean that represents the two-way integration on/off flag.
Expand Down

0 comments on commit 3560052

Please sign in to comment.