feat(destinations): add update_original_message to destination conf…

…igurations (#2701)
newrelic · Jul 9, 2024 · 3d498a3 · 3d498a3
1 parent b42dc2d
commit 3d498a3
Show file tree

Hide file tree

Showing 5 changed files with 82 additions and 2 deletions.
diff --git a/newrelic/resource_newrelic_workflow.go b/newrelic/resource_newrelic_workflow.go
@@ -64,6 +64,14 @@ func resourceNewRelicWorkflow() *schema.Resource {
 							Computed:    true,
 							Description: fmt.Sprintf("(Required) The type of the destination. One of: (%s).", strings.Join(listValidWorkflowsDestinationTypes(), ", ")),
 						},
+						// Computed
+						"update_original_message": {
+							Type:        schema.TypeBool,
+							Optional:    true,
+							DefaultFunc: func() (interface{}, error) { return true, nil },
+							Computed:    true,
+							Description: "Update original notification message (Slack channels only)",
+						},
 					},
 				},
 			},

diff --git a/newrelic/resource_newrelic_workflow_test.go b/newrelic/resource_newrelic_workflow_test.go
@@ -321,6 +321,60 @@ func TestNewRelicWorkflow_WithUpdatedNotificationTriggers(t *testing.T) {
 	})
 }
 
+func TestNewRelicWorkflow_WithCreatedUpdateOriginalMessage(t *testing.T) {
+	resourceName := "newrelic_workflow.foo"
+	rName := generateNameForIntegrationTestResource()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheckEnvVars(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccNewRelicWorkflowDestroy,
+		Steps: []resource.TestStep{
+			// Test: Create workflow
+			{
+				Config: testAccNewRelicWorkflowConfigurationWithCustomDestination(testAccountID, rName, `update_original_message = true`),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckNewRelicWorkflowExists(resourceName),
+				),
+			},
+			// Test: Update workflow
+			{
+				Config: testAccNewRelicWorkflowConfigurationWithCustomDestination(testAccountID, fmt.Sprintf("%s-updated", rName), `update_original_message = true`),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckNewRelicWorkflowExists(resourceName),
+				),
+			},
+		},
+	})
+}
+
+func TestNewRelicWorkflow_WithNonCreatedUpdateOriginalMessage(t *testing.T) {
+	resourceName := "newrelic_workflow.foo"
+	rName := generateNameForIntegrationTestResource()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheckEnvVars(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccNewRelicWorkflowDestroy,
+		Steps: []resource.TestStep{
+			// Test: Create workflow
+			{
+				Config: testAccNewRelicWorkflowConfigurationWithCustomDestination(testAccountID, rName, ""),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckNewRelicWorkflowExists(resourceName),
+				),
+			},
+			// Test: Update workflow
+			{
+				Config: testAccNewRelicWorkflowConfigurationWithCustomDestination(testAccountID, fmt.Sprintf("%s-updated", rName), `update_original_message = true`),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckNewRelicWorkflowExists(resourceName),
+				),
+			},
+		},
+	})
+}
+
 func TestNewRelicWorkflow_BooleanFlags_DisableOnUpdate(t *testing.T) {
 	channelResourceName := "foo"
 	workflowName := acctest.RandString(10)
@@ -566,6 +620,10 @@ func testAccNewRelicWorkflowConfigurationWithNotificationTriggers(accountID int,
 	if notificationTriggers != "" {
 		parsedNotificationTriggers = fmt.Sprintf(`notification_triggers = %[1]s`, notificationTriggers)
 	}
+	return testAccNewRelicWorkflowConfigurationWithCustomDestination(accountID, name, parsedNotificationTriggers)
+}
+
+func testAccNewRelicWorkflowConfigurationWithCustomDestination(accountID int, name string, customDestination string) string {
 	return fmt.Sprintf(`
 resource "newrelic_notification_destination" "foo" {
   account_id = %[1]d
@@ -630,7 +688,7 @@ resource "newrelic_workflow" "foo" {
     %[3]s
   }
 }
-`, accountID, name, parsedNotificationTriggers)
+`, accountID, name, customDestination)
 }
 
 func testAccNewRelicChannelConfigurationEmail(channelResourceName string) string {

diff --git a/newrelic/structures_newrelic_workflow.go b/newrelic/structures_newrelic_workflow.go
@@ -194,6 +194,11 @@ func expandWorkflowDestinationConfiguration(cfg map[string]interface{}) workflow
 		destinationConfigurationInput.ChannelId = channelID.(string)
 	}
 
+	if updateOriginalMessage, ok := cfg["update_original_message"]; ok {
+		b := updateOriginalMessage.(bool)
+		destinationConfigurationInput.UpdateOriginalMessage = &b
+	}
+
 	if notificationTriggers, ok := cfg["notification_triggers"]; ok {
 		for _, p := range notificationTriggers.([]interface{}) {
 			notificationTriggersInput = append(notificationTriggersInput, workflows.AiWorkflowsNotificationTrigger(p.(string)))
@@ -407,6 +412,12 @@ func flattenWorkflowDestinationConfiguration(d *workflows.AiWorkflowsDestination
 	destinationConfigurationResult["channel_id"] = d.ChannelId
 	destinationConfigurationResult["name"] = d.Name
 	destinationConfigurationResult["type"] = d.Type
+	if currentState == nil || currentState["update_original_message"] == nil {
+		b := true
+		destinationConfigurationResult["update_original_message"] = &b
+	} else {
+		destinationConfigurationResult["update_original_message"] = d.UpdateOriginalMessage
+	}
 
 	if currentState == nil || currentState["notification_triggers"] == nil {
 		destinationConfigurationResult["notification_triggers"] = d.NotificationTriggers

diff --git a/newrelic/structures_newrelic_workflow_test.go b/newrelic/structures_newrelic_workflow_test.go
@@ -432,6 +432,8 @@ func testFlattenWorkflowsDestinationConfiguration(t *testing.T, v interface{}, c
 				assert.Equal(t, cv, string(configuration.Type))
 			case "notification_triggers":
 				assert.Equal(t, cv, configuration.NotificationTriggers)
+			case "update_original_message":
+				assert.Equal(t, cv, configuration.UpdateOriginalMessage)
 			}
 		}
 	}

diff --git a/website/docs/r/workflow.html.markdown b/website/docs/r/workflow.html.markdown
@@ -166,7 +166,8 @@ workflow.
 Block's arguments:
 * `channel_id` - (Required) Id of a [notification_channel](notification_channel.html) to use for notifications. Please note that you have to use a 
 **notification** channel, not an `alert_channel`.
-* `notification_triggers` - (Optional) Issue events to notify on. The value is a list of possible issue events. See [Notification Triggers](#notification-triggers) below for details. 
+* `notification_triggers` - (Optional) Issue events to notify on. The value is a list of possible issue events. See [Notification Triggers](#notification-triggers) below for details.
+* `update_original_message` - (Optional) Update original notification message (Slack channels only).
 
 ### Notification Triggers