Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated new cross account id and entity guid #2267

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RavitejaSurampudi
Copy link
Contributor

@RavitejaSurampudi RavitejaSurampudi commented Feb 28, 2023

Summary

This PR (updated on 27 Oct, 2023) addresses the following

  • updates to the GUID used in the value of the linked_entity_guids argument in tests of dashboard resources to a GUID that is now active in the account we use to run integration tests (the values which currently exist are outdated, belong to an older account)
  • discarding hardcoded account IDs in tests and at other points in the code, such as the example found in the AWS Govcloud Integrations resource and replacing such references with testAccountID and testSubAccountID
  • refactoring in the tests of the newrelic_entity data source similar to the above (though the subaccount ID used here could not be eliminated as this is a second subaccount of testAccountID and is not comprised by GitHub secrets at the moment)

@pranav-new-relic pranav-new-relic force-pushed the rt/NR-88943 branch 2 times, most recently from 57131ce to 28cd432 Compare October 27, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant