Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud-integrations): Add GCP and AWS cloud integrations #2669

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

abasha1234
Copy link
Member

@abasha1234 abasha1234 commented May 21, 2024

This PR will add Integrations GcpAiPlatform, AwsMsElasticache to Cloud Integration Resources

Ticket: NR-266295

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@pranav-new-relic
Copy link
Member

great job with this @abasha1234. Will shortly take a look at this PR.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.27273% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 32.85%. Comparing base (92361de) to head (7890cb1).
Report is 22 commits behind head on main.

Files Patch % Lines
...wrelic/resource_newrelic_cloud_gcp_integrations.go 27.27% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
+ Coverage   32.82%   32.85%   +0.03%     
==========================================
  Files          98       98              
  Lines       26884    27494     +610     
==========================================
+ Hits         8824     9034     +210     
- Misses      17902    18299     +397     
- Partials      158      161       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants