Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(key transaction): Migrate key transaction data source from Rest api to NerdGraph #2753

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

vagrawal-newrelic
Copy link
Contributor

@vagrawal-newrelic vagrawal-newrelic commented Oct 9, 2024

Updated the key transaction data source to migrate from lagacy Rest Api to NerdGraph Api.
Added some featured as part of the update

  • Added additional capability of filtering of the key transaction on the basis of guid id multiple key transaction have same same.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • add newrelic_key_transaction data block in Config file
  • perform terraform apply
  • key transaction details should be visible in the state file

@pranav-new-relic pranav-new-relic merged commit 2e72740 into main Oct 9, 2024
11 of 12 checks passed
@pranav-new-relic pranav-new-relic deleted the key-transaction-rest-to-nerdgraph branch October 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants