Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboards): Added a new field called excluded in newrelic_one_dashboard resource (Testing PR) #2756

Merged
merged 11 commits into from
Oct 28, 2024
Merged

feat(dashboards): Added a new field called excluded in newrelic_one_dashboard resource (Testing PR) #2756

merged 11 commits into from
Oct 28, 2024

Conversation

shashank-reddy-nr
Copy link
Contributor

@shashank-reddy-nr shashank-reddy-nr commented Oct 14, 2024 •
edited by pranav-new-relic
Loading

Ticket: https://new-relic.atlassian.net/browse/NR-320971

Changes Done:

  • Added support for new field called excluded in newrelic_one_dashboard.
  • Made integration test changes.

Pending Action Items:

  • Validating all cases with this changes.
  • We shouldn't see any drift if users don't specify these fields or even if they speicfy one field out of these two.(excluded, ignore_time_range). Need to test this properly.

@shashank-reddy-nr shashank-reddy-nr marked this pull request as draft October 14, 2024 04:29
shashank-reddy-nr and others added 10 commits October 28, 2024 17:04
@vinay-newrelic vinay-newrelic marked this pull request as ready for review October 28, 2024 11:57
@pranav-new-relic pranav-new-relic merged commit 4c1e489 into main Oct 28, 2024
11 of 12 checks passed
@pranav-new-relic pranav-new-relic deleted the NR-320971 branch October 28, 2024 15:13
@shashank-reddy-nr
Copy link
Contributor Author

Approved

@Nandu-pns
Copy link
Contributor

Approved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranav-new-relic pranav-new-relic pranav-new-relic approved these changes

Assignees

@vinay-newrelic vinay-newrelic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shashank-reddy-nr @Nandu-pns @pranav-new-relic @vinay-newrelic