Tracker Implementation with latest library of Dash.js #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpradhan-nr
previously approved these changes
Sep 18, 2024
| @@ -0,0 +1 @@ | |||
| FROM node:7 | |||
asllop
reviewed
Sep 20, 2024
asllop
reviewed
Sep 20, 2024
mlychndnnr
dismissed
jpradhan-nr’s stale review
The merge-base changed after approval.
jpradhan-nr
approved these changes
Sep 30, 2024
| @@ -0,0 +1,106 @@ | |||
| // All dash events | |||
There was a problem hiding this comment.
Can we add this into CONSTANTS folder / file
| ]); | ||
|
|
||
| this.player.on("streamInitialized", this.onReady.bind(this)); | ||
| this.player.on("playbackMetaDataLoaded", this.onDownload.bind(this)); |
There was a problem hiding this comment.
can we define the event listener string values as constants and import them from a constants file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.